fix: Assorted new docs fixes from testing #8875

LFDanLu · 2025-09-16T23:39:07Z

Does the following:

404 page
Fix to DropZone max width so it renders nicely on mobile
Fixes ImageCoordinator example so it doesn't squish the images on small screen sizes
Fixes label and icons in MobileHeader, especially the React Aria/Internationalization icons
Fixes navigation on mobile so that you only need to tap once in the search menu to go to a new page and scrolling properly updates the section header
update S2 popover example to have better padding and fit various sizes

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

See the above

🧢 Your Project:

RSP

rspbot · 2025-09-16T23:46:44Z

Build successful! 🎉

rspbot · 2025-09-18T17:49:18Z

Build successful! 🎉

rspbot · 2025-09-18T19:38:46Z

Build successful! 🎉

snowystinger · 2025-09-22T01:52:19Z

packages/dev/s2-docs/src/TitleResizer.tsx

+
+// TODO: this causes a flash when the headings change size, maybe we just move this code
+// to client and append suppressHydrationWarning to the h1s
+export function TitleResizer() {


Want to use https://una.im/5-css-functions/#fluid-type if it's supported in the browser?
it's already in chrome Fyrd/caniuse#7368

hit the wrong button

rspbot · 2025-09-22T18:01:44Z

Build successful! 🎉

…gation scroll positioning

… the images at small screen sizes

…wrap

…r updates during scroll on mobile this is because the page doesnt actually remount, we reuse the existing component tree

rspbot · 2025-09-29T17:36:55Z

Build successful! 🎉

packages/dev/s2-docs/src/Layout.tsx

rspbot · 2025-09-29T19:03:47Z

Build successful! 🎉

rspbot · 2025-10-03T18:14:52Z

Build successful! 🎉

reidbarber

Looks great! Just a few comments

packages/dev/s2-docs/pages/s2/Accordion.mdx

packages/dev/s2-docs/src/Layout.tsx

rspbot · 2025-10-03T18:59:48Z

Build successful! 🎉

rspbot · 2025-10-06T15:38:00Z

Build successful! 🎉

rspbot · 2025-10-06T15:59:05Z

Build successful! 🎉

LFDanLu · 2025-10-06T23:26:47Z

packages/dev/s2-docs/pages/s2/Popover.mdx

I poked around with this example and decided to update it entirely since the Form + CheckboxGroup looks strange when the size was increased via the controls

rspbot · 2025-10-06T23:33:25Z

Build successful! 🎉

rspbot · 2025-10-06T23:33:26Z

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:EditableCell

-EditableCell {
-  align?: 'start' | 'center' | 'end' = 'start'
-  children: ReactNode
-  className?: ClassNameOrFunction<CellRenderProps> = 'react-aria-Cell'
-  colSpan?: number
-  id?: Key
-  isSaving?: boolean
-  onCancel: () => void
-  onSubmit: () => void
-  renderEditing: () => ReactNode
-  showDivider?: boolean
-  style?: StyleOrFunction<CellRenderProps>
-  textValue?: string
-}

LFDanLu force-pushed the docs_fixes branch from 5ad8f8f to 07687f1 Compare September 19, 2025 16:59

LFDanLu changed the base branch from main to s2-docs-more September 19, 2025 17:00

snowystinger previously approved these changes Sep 22, 2025

View reviewed changes

Base automatically changed from s2-docs-more to main September 29, 2025 01:34

LFDanLu added 10 commits September 29, 2025 10:02

fix modal so it always appears over mobile header and fix dropzone width

c9aa612

add title font size resizing behavior to s2 docs

0ecf094

dont use useResizeObserver because we want to catch fonts changing

96e5138

fix mobile header icon and library label

8827283

fix cross page anchor navigation scrolling and mobile cross page navi…

ebc6a23

…gation scroll positioning

properly close mobile header menu when clicking on component card

36b0463

making image coordinator example wrap to new row instead of squishing…

52f64c5

… the images at small screen sizes

set a minwidth large enough so disallowEmptySelection have its label …

c7c7a30

…wrap

properly reobserve the new page post-navigation so the page nav picke…

987cff4

…r updates during scroll on mobile this is because the page doesnt actually remount, we reuse the existing component tree

remove broken title resizer code and fix rebase

48b0cd1

LFDanLu force-pushed the docs_fixes branch from 10f58a4 to 48b0cd1 Compare September 29, 2025 17:29

LFDanLu changed the title ~~fix: (WIP) Assorted new docs fixes from testing~~ fix: Assorted new docs fixes from testing Sep 29, 2025

LFDanLu marked this pull request as ready for review September 29, 2025 17:29

reidbarber reviewed Sep 29, 2025

View reviewed changes

packages/dev/s2-docs/src/Layout.tsx Show resolved Hide resolved

restore styles

74ef767

snowystinger previously approved these changes Sep 29, 2025

View reviewed changes

yihuiliao previously approved these changes Sep 30, 2025

View reviewed changes

yihuiliao added the release label Sep 30, 2025

LFDanLu removed the release label Oct 1, 2025

Merge branch 'main' of github.com:adobe/react-spectrum into docs_fixes

e3bfb1c

LFDanLu dismissed stale reviews from yihuiliao and snowystinger via e3bfb1c October 2, 2025 23:03

fix internationalized logo

451ac67

snowystinger previously approved these changes Oct 2, 2025

View reviewed changes

add 404 page

1d5918e

LFDanLu dismissed snowystinger’s stale review via 1d5918e October 3, 2025 18:06

reidbarber reviewed Oct 3, 2025

View reviewed changes

packages/dev/s2-docs/pages/s2/Accordion.mdx Outdated Show resolved Hide resolved

packages/dev/s2-docs/src/Layout.tsx Outdated Show resolved Hide resolved

LFDanLu added 2 commits October 3, 2025 11:40

Merge branch 'main' of github.com:adobe/react-spectrum into docs_fixes

ed3fdf5

forgot to remove test code

018be32

Merge remote-tracking branch 'origin/main' into docs_fixes

e2aaa67

hide error page from search

f1ee9ed

reidbarber previously approved these changes Oct 6, 2025

View reviewed changes

LFDanLu added the ready for review label Oct 6, 2025

LFDanLu added 2 commits October 6, 2025 15:55

update S2 popover example

4ef11a8

update icon in example

8c9b45f

LFDanLu dismissed reidbarber’s stale review via 8c9b45f October 6, 2025 23:22

LFDanLu commented Oct 6, 2025

View reviewed changes

reidbarber approved these changes Oct 7, 2025

View reviewed changes

snowystinger approved these changes Oct 8, 2025

View reviewed changes

LFDanLu added this pull request to the merge queue Oct 8, 2025

Merged via the queue into main with commit 97dc667 Oct 8, 2025
33 checks passed

LFDanLu deleted the docs_fixes branch October 8, 2025 16:52

fix: Assorted new docs fixes from testing #8875

fix: Assorted new docs fixes from testing #8875

Conversation

LFDanLu commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

Uh oh!

rspbot commented Sep 16, 2025

Uh oh!

rspbot commented Sep 18, 2025

Uh oh!

rspbot commented Sep 18, 2025

Uh oh!

snowystinger Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

rspbot commented Sep 22, 2025

Uh oh!

rspbot commented Sep 29, 2025

Uh oh!

Uh oh!

rspbot commented Sep 29, 2025

Uh oh!

rspbot commented Oct 3, 2025

Uh oh!

reidbarber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rspbot commented Oct 3, 2025

Uh oh!

rspbot commented Oct 6, 2025

Uh oh!

rspbot commented Oct 6, 2025

Uh oh!

LFDanLu Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

rspbot commented Oct 6, 2025

Uh oh!

rspbot commented Oct 6, 2025

@react-spectrum/s2

/@react-spectrum/s2:EditableCell

Uh oh!

Uh oh!

Uh oh!

LFDanLu commented Sep 16, 2025 •

edited

Loading